Add ignore_eos option to GenerationConfig #16912
Open
+22
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16912
Note: Links to docs will display an error until the docs builds have been completed. ❌ 5 New FailuresAs of commit 69e3d17 with merge base 3914a7e ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Contributor
kimishpatel
approved these changes
Jan 27, 2026
Contributor
kimishpatel
left a comment
kimishpatel
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
This PR needs a
|
Summary: Allow LLM generation to continue until max_new_tokens is reached, even after encountering EOS tokens. This is useful for benchmarking and testing scenarios where complete token generation is desired regardless of natural stopping points. Reviewed By: kimishpatel Differential Revision: D91183072
navsud
force-pushed
the
export-D91183072
branch
from
01fbe42 to
69e3d17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Allow LLM generation to continue until max_new_tokens is reached, even after encountering EOS tokens. This is useful for benchmarking and testing scenarios where complete token generation is desired regardless of natural stopping points.
Reviewed By: kimishpatel
Differential Revision: D91183072